Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document sortOptions field #306

Merged
merged 1 commit into from
Feb 2, 2023
Merged

Document sortOptions field #306

merged 1 commit into from
Feb 2, 2023

Conversation

yanniszark
Copy link
Contributor

Kustomize has a new field called "sortOptions" to sort resources: kubernetes-sigs/kustomize#3913 kubernetes-sigs/kustomize#4019

Document what it does and how to use it.

cc @natasha41575

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 9, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @yanniszark!

It looks like this is your first PR to kubernetes-sigs/cli-experimental 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cli-experimental has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 9, 2022
@natasha41575 natasha41575 mentioned this pull request Dec 14, 2022
Closed
KnVerey
KnVerey reviewed Jan 6, 2023
View reviewed changes
Copy link
Contributor

@KnVerey KnVerey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I have some suggestions, but the structure looks good overall. I would also suggest changing instances of "we" to "Kustomize". Though our docs aren't consistent about it, the k8s style guide says to avoid "we".

site/content/en/references/kustomize/kustomization/sortoptions/_index.md Outdated Show resolved Hide resolved
site/content/en/references/kustomize/kustomization/sortoptions/_index.md Outdated Show resolved Hide resolved
site/content/en/references/kustomize/kustomization/sortoptions/_index.md Outdated Show resolved Hide resolved
site/content/en/references/kustomize/kustomization/sortoptions/_index.md Outdated Show resolved Hide resolved
site/content/en/references/kustomize/kustomization/sortoptions/_index.md Outdated Show resolved Hide resolved
site/content/en/references/kustomize/kustomization/sortoptions/_index.md Outdated Show resolved Hide resolved
site/content/en/references/kustomize/kustomization/sortoptions/_index.md Outdated Show resolved Hide resolved
site/content/en/references/kustomize/kustomization/sortoptions/_index.md Show resolved Hide resolved
site/content/en/references/kustomize/kustomization/sortoptions/_index.md Outdated Show resolved Hide resolved
site/content/en/references/kustomize/kustomization/sortoptions/_index.md Show resolved Hide resolved
@yanniszark yanniszark force-pushed the feature-sortoptions-docs branch 2 times, most recently from 624c85f to dc44403 Compare January 11, 2023 12:46
@yanniszark
Document sortOptions field
63ee760 
Kustomize has a new field called "sortOptions" to sort resources:
kubernetes-sigs/kustomize#3913
kubernetes-sigs/kustomize#4019

Document what it does and how to use it.

Signed-off-by: Yannis Zarkadas <[email protected]>
@yanniszark
Copy link
Contributor Author

@KnVerey made all the requested changes!

@KnVerey
Copy link
Contributor

KnVerey commented Jan 14, 2023

/lgtm

Looks great, thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 14, 2023
@KnVerey
Copy link
Contributor

KnVerey commented Feb 2, 2023

5.0 is out!

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: KnVerey, yanniszark

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 2, 2023
@k8s-ci-robot k8s-ci-robot merged commit 12b1077 into kubernetes-sigs:master Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KnVerey KnVerey KnVerey left review comments

@Liujingfang1 Liujingfang1 Awaiting requested review from Liujingfang1

@monopole monopole Awaiting requested review from monopole

Assignees

@KnVerey KnVerey

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yanniszark @k8s-ci-robot @KnVerey